Re: [git pull] PCI changes

From: Linus Torvalds
Date: Wed Jan 11 2012 - 22:38:55 EST


On Wed, Jan 11, 2012 at 10:34 AM, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote:
>
> Matthew Garrett (1):
>      PCI: Rework ASPM disable code

Yay.

However, looking this through some more, I'm still a bit confused by
the pcie_clear_aspm() call in acpi_pci_root_add().

It seems to be explicitly against the rules elsewhere - we clear ASPM
even though ACPI_FADT_NO_ASPM is set - which the changelog (and the
other parts of that commit) says means "don't touch pre-existing ASPM
state").

So why is acpi_pci_root_add() special? Cna you explain that part to me?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/