Re: Add Dell Studio 1557 to pci=nocrs blacklist
From: Bjorn Helgaas
Date: Wed Jan 11 2012 - 11:08:17 EST
On Wed, Jan 4, 2012 at 11:37 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
>
> * Dave Jones <davej@xxxxxxxxxx> wrote:
>
>> The Dell Studio 1557 also doesn't suspend correctly when CRS is enabled.
>> Details at https://bugzilla.redhat.com/show_bug.cgi?id=769657
>>
>> Reported-by: Gregory S. Hoerner <ghoerner@xxxxxxxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
>>
>> --- linux-3.1.noarch/arch/x86/pci/acpi.c~ 2012-01-04 11:19:36.783664477 -0500
>> +++ linux-3.1.noarch/arch/x86/pci/acpi.c 2012-01-04 11:23:42.403666272 -0500
>> @@ -75,6 +75,16 @@ static const struct dmi_system_id pci_us
>> /* https://bugzilla.redhat.com/show_bug.cgi?id=769657 */
>> {
>> .callback = set_nouse_crs,
>> + .ident = "Dell Studio 1557",
>> + .matches = {
>> + DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "Studio 1557");
>> + DMI_MATCH(DMI_BIOS_VERSION, "A09"),
>
> Btw., should we perhaps match on all things 'Studio*'? For these
> two systems i'm sure there's 20 other models we have not covered
> yet ...
+linux-pci
I think we should hold off on merging this patch upstream. We don't
understand the root cause yet, and I haven't seen any evidence that
setting "pci=nocrs" actually makes a difference in PCI resource
allocation (https://bugzilla.redhat.com/show_bug.cgi?id=769657#c27)
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/