Re: [PATCH] mm: vmscan: no change of reclaim mode if unevictablepage encountered

[Mel Gorman]

On Sat, Jan 07, 2012 at 11:46:17AM +0800, Hillf Danton wrote:
> Since unevictable page is not isolated from lru list for shrink_page_list(),
> it is accident if encountered in shrinking, and no need to change reclaim mode.
> 

This changelog does does not explain the problem, does not explain
what is fixed or what the impact is.

It also does not make sense. It says "unevictable page is not isolated
from LRU list" but this is shrink_page_list() and the page has already
been isolated (probably by lumpy reclaim). It will be put back on
the LRU_UNEVICTABLE list.

It might be the case that resetting the reclaim mode after encountering
mlocked pages is overkill but that would need more justification than
what this changelog offers. Resetting the mode impacts THP rates but
this is erring on the side of caution by doing less work in reclaim
as the savings from THP may not offset the cost of reclaim.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/