[patch] cpuidle: checking the wrong variable in__cpuidle_register_device()

From: Dan Carpenter
Date: Mon Jan 09 2012 - 05:55:17 EST


We updated this in 8a25a2fd12 "cpu: convert 'cpu' and 'machinecheck'
sysdev_class to a regular subsystem" but it should be checking "cpu_dev"
here not "dev". The "dev" variable was dereferenced already.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 59f4261..7771810 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -294,7 +294,7 @@ static int __cpuidle_register_device(struct cpuidle_device *dev)
struct device *cpu_dev = get_cpu_device((unsigned long)dev->cpu);
struct cpuidle_driver *cpuidle_driver = cpuidle_get_driver();

- if (!dev)
+ if (!cpu_dev)
return -EINVAL;
if (!try_module_get(cpuidle_driver->owner))
return -EINVAL;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/