Re: [RFC PATCH v2 1/9] arm: avoid using on_each_cpu hard coded ret value

[Gilad Ben-Yossef]

On Sun, Jan 8, 2012 at 6:12 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxxx> wrote:

<SNIP>

>> diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
>> index 5bb91bf..6e9acb7 100644
>> --- a/arch/arm/kernel/perf_event.c
>> +++ b/arch/arm/kernel/perf_event.c
>> @@ -616,7 +616,7 @@ static int __init
>>  cpu_pmu_reset(void)
>>  {
>>       if (cpu_pmu && cpu_pmu->reset)
>> -             return on_each_cpu(cpu_pmu->reset, NULL, 1);
>> +             on_each_cpu(cpu_pmu->reset, NULL, 1);
>
> There's not much to review here...

Oh, I've introduced fatal bugs with less... :-)

Thanks for the review.
Gilad


-- 
Gilad Ben-Yossef
Chief Coffee Drinker
gilad@xxxxxxxxxxxxx
Israel Cell: +972-52-8260388
US Cell: +1-973-8260388
http://benyossef.com

"Unfortunately, cache misses are an equal opportunity pain provider."
-- Mike Galbraith, LKML
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/