Re: [PATCH] cgroup: fix to allow mounting a hierarchy by name

From: Tejun Heo
Date: Thu Jan 05 2012 - 21:28:01 EST


Hello,

On Fri, Jan 06, 2012 at 10:24:47AM +0800, Li Zefan wrote:
> There's a corner case where "mount --bind" can't be used:
>
> # mount -t cgroup -o none,name=hier1 xxx /mnt
> # mkdir /mnt/tmp
> # umount /mnt
>
> Since there's a sub-cgroup in it, umount won't destroy the hierarchy,
> but "hide" it, so the name=xxx is necessary to re-mount it.
>
> > Also, what's the use case for
> > mounting the same cgroup directory multiple times? Why is that
> > necessary? Is it useful for some namespace-savvy setup?
>
> I don't have a use case in real life. It was made so at the very
> beginning of cgroup, and we should't break it without strong reasons.
> We can mount other pseudo filesystems like procfs, sysfs and debugfs
> multiple times, right?

Yeah, we shouldn't break it so I applied the patch with a lot of
grumbling. This is something which shouldn't have existed at all. :(

Thanks a lot for the explanation and patience.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/