Re: [PATCH] power_supply: wm97xx_battery: Use DEFINE_MUTEX() forwork_lock

From: Anton Vorontsov
Date: Thu Jan 05 2012 - 20:09:14 EST


On Mon, Nov 28, 2011 at 10:37:35PM +0800, Axel Lin wrote:
> work_lock can be initialized automatically with
> DEFINE_MUTEX() rather than explicitly calling mutex_init().
>
> This patch also removes an unused bat_lock mutex.
>
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>

Applied, thanks!

> ---
> drivers/power/wm97xx_battery.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/power/wm97xx_battery.c b/drivers/power/wm97xx_battery.c
> index cf8681c..eaa454b 100644
> --- a/drivers/power/wm97xx_battery.c
> +++ b/drivers/power/wm97xx_battery.c
> @@ -25,9 +25,8 @@
> #include <linux/irq.h>
> #include <linux/slab.h>
>
> -static DEFINE_MUTEX(bat_lock);
> static struct work_struct bat_work;
> -static struct mutex work_lock;
> +static DEFINE_MUTEX(work_lock);
> static int bat_status = POWER_SUPPLY_STATUS_UNKNOWN;
> static enum power_supply_property *prop;
>
> @@ -181,8 +180,6 @@ static int __devinit wm97xx_bat_probe(struct platform_device *dev)
> if (dev->id != -1)
> return -EINVAL;
>
> - mutex_init(&work_lock);
> -
> if (!pdata) {
> dev_err(&dev->dev, "No platform_data supplied\n");
> return -EINVAL;
> --
> 1.7.5.4

--
Anton Vorontsov
Email: cbouatmailru@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/