Re: [PATCH] PCI: Increase resource array mask bit size in pcim_iomap_regions()

[Don Dutile]

On 01/04/2012 06:50 PM, Yinghai Lu wrote:
> DEVICE_COUNT_RESOURCE will be bigger than 16 when SRIOV supported is enabled.
>
> Let them pass with int just like pci_enable_resources().
>
> Signed-off-by: Yinghai Lu<yinghai@xxxxxxxxxx>
>
> ---
>   include/linux/pci.h |    6 +++---
>   lib/devres.c        |    6 +++---
>   2 files changed, 6 insertions(+), 6 deletions(-)
>
> Index: linux-2.6/include/linux/pci.h
> ===================================================================
> --- linux-2.6.orig/include/linux/pci.h
> +++ linux-2.6/include/linux/pci.h
> @@ -1433,10 +1433,10 @@ static inline void pci_fixup_device(enum
>   void __iomem *pcim_iomap(struct pci_dev *pdev, int bar, unsigned long maxlen);
>   void pcim_iounmap(struct pci_dev *pdev, void __iomem *addr);
>   void __iomem * const *pcim_iomap_table(struct pci_dev *pdev);
> -int pcim_iomap_regions(struct pci_dev *pdev, u16 mask, const char *name);
> -int pcim_iomap_regions_request_all(struct pci_dev *pdev, u16 mask,
> +int pcim_iomap_regions(struct pci_dev *pdev, int mask, const char *name);
> +int pcim_iomap_regions_request_all(struct pci_dev *pdev, int mask,
>   				   const char *name);
> -void pcim_iounmap_regions(struct pci_dev *pdev, u16 mask);
> +void pcim_iounmap_regions(struct pci_dev *pdev, int mask);
>
> [...]

I'd recommend u32 since it was u16 initially.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/