Re: [PATCH] tty: cleanup prohibition of direct opening for unix98pty master

From: Greg KH
Date: Mon Jan 02 2012 - 20:10:25 EST


On Tue, Jan 03, 2012 at 02:29:08AM +0400, Konstantin Khlebnikov wrote:
> Greg KH wrote:
> >On Mon, Jan 02, 2012 at 09:22:31PM +0400, Konstantin Khlebnikov wrote:
> >>cleanup hack added in v2.6.27-3203-g15582d3
> >>
> >>comment from that patch:
> >>
> >>: pty: If the administrator creates a device for a ptmx slave we should not error
> >>:
> >>: The open path for ptmx slaves is via the ptmx device. Opening them any
> >>: other way is not allowed. Vegard Nossum found that previously this was not
> >>: the case and mknod foo c 128 42; cat foo would produce nasty diagnostics
> >>:
> >>: Signed-off-by: Alan Cox<alan@xxxxxxxxxx>
> >>: Signed-off-by: Linus Torvalds<torvalds@xxxxxxxxxxxxxxxxxxxx>
> >
> >Any reason why you didn't include these two people on this patch?
> >Perhaps they might wish to review it...
>
> This is just simple cleanup patch.

Even so, please resend and copy them.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/