Re: [PATCH 5/6] Staging: comedi: fix line over 80 character issuein daqboard2000.c

From: Ryan Mallon
Date: Mon Jan 02 2012 - 15:46:12 EST


On 03/01/12 00:10, Ravishankar karkala Mallikarjunayya wrote:
> This is a patch to the daqboard2000.c file that fixes up a
> line over 80 character warning found by the checkpatch.pl tool.
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@xxxxxxxxxxxxxxx>
> ---
> drivers/staging/comedi/drivers/daqboard2000.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
> index e61c6a8..3550c6a 100644
> --- a/drivers/staging/comedi/drivers/daqboard2000.c
> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
> @@ -414,7 +414,7 @@ static int daqboard2000_ai_insn_read(struct comedi_device *dev,
>
> /* If pacer clock is not set to some high value (> 10 us), we
> risk multiple samples to be put into the result FIFO. */
> - fpga->acqPacerClockDivLow = 1000000; /* 1 second, should be long enough */
> + /* 1 second, should be long enough */

You broke the driver here.

> fpga->acqPacerClockDivHigh = 0;
>
> gain = CR_RANGE(insn->chanspec);
> @@ -526,7 +526,8 @@ static void daqboard2000_pulseProgPin(struct comedi_device *dev)
> writel(DAQBOARD2000_SECRProgPinHi, devpriv->plx + 0x6c);
> udelay(10000);
> writel(DAQBOARD2000_SECRProgPinLo, devpriv->plx + 0x6c);
> - udelay(10000); /* Not in the original code, but I like symmetry... */
> + /* Not in the original code, but I like symmetry... */
> + udelay(10000);
> }
>
> static int daqboard2000_pollCPLD(struct comedi_device *dev, int mask)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/