Re: [PATCH] input: signedness bug in cma3000_thread_irq()

From: Dmitry Torokhov
Date: Thu Dec 22 2011 - 12:50:30 EST


On Thu, Dec 15, 2011 at 05:17:02PM -0500, Xi Wang wrote:
> On Dec 14, 2011, at 10:21 PM, Valdis.Kletnieks@xxxxxx wrote:
> > No, the variable that used to be a u8 - was it 8 bits wide for a reason?
>
> The return value of CMA3000_READ? I don't see any particular reason.
>

The data returned by CMA3000_READ() is a byte, so that's the reason (and
I am guessing here) that the author used u8 to store the result,
forgetting that the range was extended to report error conditions.

--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/