Re: BUG: unable to handle kernel NULL pointer dereference inipv6_select_ident

From: Eric Dumazet
Date: Thu Dec 22 2011 - 03:05:45 EST


Le jeudi 22 dÃcembre 2011 Ã 08:58 +0100, Steffen Klassert a Ãcrit :
> On Thu, Dec 22, 2011 at 08:51:17AM +0100, Eric Dumazet wrote:
> >
> > Prior to 618f9bc74a0, we were calling
> >
> > static inline u32 dst_mtu(const struct dst_entry *dst)
> > {
> > u32 mtu = dst_metric_raw(dst, RTAX_MTU);
> >
> > if (!mtu)
> > mtu = dst->ops->mtu(dst);
> >
> > return mtu;
> > }
> >
> > with dst = fake_rtable
> >
> > and we did :
> >
> > dst_init_metrics(&rt->dst, br_dst_default_metrics, true);
> >
> > so dst_metric_raw(dst, RTAX_MTU) was returning 1500
> >
> > So bug is new, we dont need to backport this fix.
> >
>
> Ok, I see. Thanks for pointing it out!

You're welcome.

By the way we no longer have this 1500 hard coded, not sure it it
matters or not, but it looks better anyway.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/