linux-next: build failure after merge of the vfs tree

From: Stephen Rothwell
Date: Wed Dec 21 2011 - 19:16:05 EST


Hi Al,

After merging the vfs tree, today's linux-next build (powerpc ppc64_defconfig)
failed like this:

In file included from ipc/util.c:28:0:
include/linux/security.h: In function 'security_real_capable':
include/linux/security.h:1886:25: error: dereferencing pointer to incomplete type
include/linux/security.h:1886:25: error: dereferencing pointer to incomplete type
include/linux/security.h:1886:25: error: dereferencing pointer to incomplete type
include/linux/security.h:1886:25: error: dereferencing pointer to incomplete type
include/linux/security.h:1886:25: error: dereferencing pointer to incomplete type

And so on ... These are the references to __task_cred() which dereferences
a "struct task_struct *". Adding an include of linux/sched.h back to
linux/security.h (which was removed by commit ae1a442f9d95 ("trim
security.h")) results in this error (to be fair, the include of
linux-sched.h really belongs in cred.h):

arch/powerpc/platforms/cell/spu_syscalls.c:68:22: error: expected ')' before 'const'

Which was caused by commit 2dbc0a0f41d4 ("switch spu_create(2) to use of
SYSCALL4, make it use umode_t"). That commit (along with a whole string
of others around it) was supposedly authored July 27, 2011, so it would
have been nice to see them earlier then this in linux-next. :-(

I have used the vfs tree from next-20111216 (which is unfortunately
empty) again for today.

BTW, the x86_64 allmodconfig build (with out the sched.h include
restored) does not get any of these errors, so sches.h must be being
indirectly included, so you are not saving anything on x86_64 by removing
the sched.h include from security.h.
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature