Re: [PATCH 7/8] cpufreq: Add support for x86 cpuinfo auto loadingv3

[H. Peter Anvin]

On 12/21/2011 12:12 PM, Andi Kleen wrote:
>>> +static const struct x86_cpu_id powernow_k8_ids[] = {
>>> +	{ X86_VENDOR_AMD, 0xf, },
>>> +	{ X86_VENDOR_AMD, 0x10, },
>>> +	{ X86_VENDOR_AMD, 0x11, },
>>> +	{ X86_VENDOR_AMD, 0x12, },
>>> +	{ X86_VENDOR_AMD, 0x13, },
>>> +	{ X86_VENDOR_AMD, 0x14, },
>> { X86_VENDOR_AMD, 0x15, },
>>
>> Should also have BullDozer family included.
> 
> I think it really needs a cpuid feature bit for the hwpstate.  This is
> not in one of the normal CPUID leaves, so the amd specific CPU init
> code would need to set it.
> 
> I added 0x15 for now, but it would be good if someone with the hardware
> fixed it like this.
> 
> Then could just add a match on "AMD-hw pstate" or so.
> 

Agreed.  This is literally screaming for a synthetic CPUID bit.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/