mempool && io_schedule_timeout()

[Oleg Nesterov]

On 12/20, Tejun Heo wrote:
>
> -	if (!pool->curr_nr) {
> -		/*
> -		 * FIXME: this should be io_schedule().  The timeout is there
> -		 * as a workaround for some DM problems in 2.6.18.
> -		 */
> -		io_schedule_timeout(5*HZ);
> -	}
> -	finish_wait(&pool->wait, &wait);
>
> +	spin_unlock_irqrestore(&pool->lock, flags);
> +
> +	/*
> +	 * FIXME: this should be io_schedule().  The timeout is there as a
> +	 * workaround for some DM problems in 2.6.18.
> +	 */
> +	io_schedule_timeout(5*HZ);

Just curious... This was added by 0b1d647a in 2006.

Perhaps the problem was already fixed?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/