Re: [PATCH 3/3] HID: usbhid: defer LED setting to a workqueue

From: Jiri Kosina
Date: Wed Dec 21 2011 - 05:19:29 EST


On Tue, 20 Dec 2011, Oliver Neukum wrote:

> > > > Could you please be more specific about what this patch breaks and
> > > > perhaps give some guidance on how to fix it?
> > >
> > > It breaks nothing. It just continues a bug and I assumed it was not present.
> > > Basically the work queue must do nothing after pre_reset() and post_reset()
> > > ought to rerun the work in case some request came down during that time.
> >
> > So, is this an Ack for this patchset?
> > Can we fix any existing races in later patches?
>
> Very well. You are fixing a bad bug and not making matters worse.
>
> Acked-by: Oliver Neukum <oneukum@xxxxxxx>

Thanks guys. Applied.

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/