Re: [Regression, bisected] a3e06bbe8445f57eb949e6474c5a9b30f24d2057:KVM: emulate lapic tsc deadline timer for guest"

From: Avi Kivity
Date: Wed Dec 21 2011 - 04:18:33 EST


On 12/20/2011 09:21 PM, Liu, Jinsong wrote:
> Yes, my fault to say 'walk around' before knowing Alex's issue clearly.
>
> After Alex send his last email to clarify the situation, I have checked the bug.
> Basically it caused from
> 1. qemu didn't issue KVM_CREATE_IRQCHIP, hence irqchip_in_kernel(kvm) fail when setup vcpu lapic logic at kvm_arch_vcpu_init();
> 2. tsc deadline work based on vcpu lapic, hence break illumos;
>
> A fix is to update cpuid, as you said, setting it after KVM_CREATE_IRQCHIP.

Wait, qemu set up a vcpu with TSC deadline timer in cpuid, but with
userspace apic? Then it was clearly lying, since qemu doesn't implement
the TSC deadline timer.

> I just wonder is there any better solution? so I ask Alex his environment to setup at my side to do more test.
> If you think kvm tsc deadline timer patch itself not clean, please tell me.
>

Alexey, did you use -cpu host?

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/