Re: [PATCH] block: fix blk_queue_end_tag()

[Tao Ma]

On 12/21/2011 02:36 PM, Meelis Roos wrote:
>>> -	if (unlikely(tag >= bqt->max_depth)) {
>>> +	if (WARN_ONCE(tag >= bqt->real_max_depth,
>>> +		      "%s: tag %d greater than tag map size: %d\n",
>>> +		      __func__, tag, bqt->real_max_depth)) {
>>>  		/*
>>>  		 * This can happen after tag depth has been reduced.
>> Please also change the comments here since it should never happen in the
>> right workload.
> 
> What do you mean by right workload? Normal workload?
yeah, so real_max_depth is the maximum depth we ever have. So in normal
case(shrinking queue depth is also a normal user case), we should never
arrive here. In another word, if tag >= real_max_depth, we should have a
bug in the kernel.

Thanks
Tao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/