Re: [PATCH] vmalloc: remove #ifdef in function body

From: Michal Nazarewicz
Date: Wed Dec 21 2011 - 01:24:14 EST


On Wed, 21 Dec 2011 07:22:32 +0100, Minchan Kim <minchan@xxxxxxxxxx> wrote:

On Wed, Dec 21, 2011 at 07:13:49AM +0100, Michal Nazarewicz wrote:
On Wed, 21 Dec 2011 06:17:59 +0100, Minchan Kim <minchan@xxxxxxxxxx> wrote:
>We don't like function body which include #ifdef.
>If we can, define null function to go out compile time.
>It's trivial, no functional change.

It actually adds âflush_tlb_kenel_range()â call to the function so there
is functional change.

Sorry. I can't understand your point.
Why does it add flush_tlb_kernel_range in case of !CONFIG_DEBUG_PAGEALLOC?

Uh, sorry, I've totally misread the function. Never mind my comment.

--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, MichaÅ âmina86â Nazarewicz (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/