Re: [PATCH] vmalloc: remove #ifdef in function body

From: Michal Nazarewicz
Date: Wed Dec 21 2011 - 01:22:14 EST


On Wed, 21 Dec 2011 06:58:19 +0100, Joe Perches <joe@xxxxxxxxxxx> wrote:

On Wed, 2011-12-21 at 14:45 +0900, Minchan Kim wrote:
I feel it's no problem as it is because it's very short function now
but it's not style we prefer.

Who is this "we" you refer to?

There's nothing suggesting your patch as a preferred style
in Documentation/CodingStyle.

There is plenty that is not documented, ;) yet it seems the community prefers
having ifdefs outside of the function.

--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, MichaÅ âmina86â Nazarewicz (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/