Re: [PATCH] vmalloc: remove #ifdef in function body

From: Joe Perches
Date: Wed Dec 21 2011 - 00:58:21 EST


On Wed, 2011-12-21 at 14:45 +0900, Minchan Kim wrote:
> On Tue, Dec 20, 2011 at 09:31:21PM -0800, Joe Perches wrote:
> > On Wed, 2011-12-21 at 14:17 +0900, Minchan Kim wrote:
> > > We don't like function body which include #ifdef.
[]
> > I don't like this change.
> > I think it's perfectly good style to use:
> I feel it's no problem as it is because it's very short function now
> but it's not style we prefer.

Who is this "we" you refer to?

There's nothing suggesting your patch as a preferred style
in Documentation/CodingStyle.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/