Re: [PATCH 1/2] cgroup: Remove unnecessary task_lock before fetchingcss_set on migration

From: Li Zefan
Date: Tue Dec 20 2011 - 20:51:13 EST


Frederic Weisbecker wrote:
> When we fetch the css_set of the tasks on cgroup migration, we don't need
> anymore to synchronize against cgroup_exit() that could swap the old one
> with init_css_set. Now that we are using threadgroup_lock() during
> the migrations, we don't need to worry about it anymore.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>

Good catch!

Reviewed-by: Li Zefan <lizf@xxxxxxxxxxxxxx>

> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Li Zefan <lizf@xxxxxxxxxxxxxx>
> Cc: Containers <containers@xxxxxxxxxxxxxxxxxxxxxxxxxx>
> Cc: Cgroups <cgroups@xxxxxxxxxxxxxxx>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Paul Menage <paul@xxxxxxxxxxxxxx>
> Cc: Mandeep Singh Baines <msb@xxxxxxxxxxxx>
> ---
> kernel/cgroup.c | 21 +++++++++++----------
> 1 files changed, 11 insertions(+), 10 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/