Re: Current kernel fails to compile with KVM on PowerPC

[Jörg Sommer]

Hello Alexander,

JÃrg Sommer hat am Mon 07. Nov, 20:48 (+0100) geschrieben:
>   CHK     include/linux/version.h
>   HOSTCC  scripts/mod/modpost.o
>   CHK     include/generated/utsrelease.h
>   UPD     include/generated/utsrelease.h
>   HOSTLD  scripts/mod/modpost
>   GEN     include/generated/bounds.h
>   CC      arch/powerpc/kernel/asm-offsets.s
> In file included from arch/powerpc/kernel/asm-offsets.c:59:0:
> /home/joerg/git/linux/arch/powerpc/include/asm/kvm_book3s.h: In function âcompute_tlbie_rbâ:
> /home/joerg/git/linux/arch/powerpc/include/asm/kvm_book3s.h:393:10: error: âHPTE_V_SECONDARYâ undeclared (first use in this function)
> /home/joerg/git/linux/arch/powerpc/include/asm/kvm_book3s.h:393:10: note: each undeclared identifier is reported only once for each function it appears in
> /home/joerg/git/linux/arch/powerpc/include/asm/kvm_book3s.h:396:12: error: âHPTE_V_1TB_SEGâ undeclared (first use in this function)
> /home/joerg/git/linux/arch/powerpc/include/asm/kvm_book3s.h:401:10: error: âHPTE_V_LARGEâ undeclared (first use in this function)
> /home/joerg/git/linux/arch/powerpc/include/asm/kvm_book3s.h:415:2: warning: right shift count >= width of type [enabled by default]
> make[3]: *** [arch/powerpc/kernel/asm-offsets.s] Fehler 1
> make[2]: *** [prepare0] Fehler 2
> make[1]: *** [deb-pkg] Fehler 2
> make: *** [deb-pkg] Fehler 2

I'm so sorry to have to report a new bug in one of your patches. It was
covered by the one above. I've picked the commit for it from your git
repository and now, the kernel build fails with this error:

  BOOTCC  arch/powerpc/boot/fdt_strerror.o
  BOOTAR  arch/powerpc/boot/wrapper.a
  WRAP    arch/powerpc/boot/zImage.pmac
  WRAP    arch/powerpc/boot/zImage.coff
ERROR: "kvmppc_h_pr" [arch/powerpc/kvm/kvm.ko] undefined!
make[3]: *** [__modpost] Fehler 1
make[2]: *** [modules] Fehler 2
make[2]: *** Warte auf noch nicht beendete Prozesse...
  WRAP    arch/powerpc/boot/zImage.miboot
make[1]: *** [deb-pkg] Fehler 2
make: *** [deb-pkg] Fehler 2

The bug was introduced by this commit

HEAD is now at aacf9aa KVM: PPC: Stub emulate CFAR and PURR SPRs
a668f2bd3f14ce7f92e119f4b5d9b50cdc59e855 is the first bad commit
commit a668f2bd3f14ce7f92e119f4b5d9b50cdc59e855
Author: Alexander Graf <agraf@xxxxxxx>
Date:   Mon Aug 8 17:26:24 2011 +0200

    KVM: PPC: Support SC1 hypercalls for PAPR in PR mode
    
    PAPR defines hypercalls as SC1 instructions. Using these, the guest modifies
    page tables and does other privileged operations that it wouldn't be allowed
    to do in supervisor mode.
    
    This patch adds support for PR KVM to trap these instructions and route them
    through the same PAPR hypercall interface that we already use for HV style
    KVM.
    
    Signed-off-by: Alexander Graf <agraf@xxxxxxx>

Bye, JÃrg.
-- 
âPerlâthe only language that looks the same
 before and after RSA encryption.â           (Keith Bostic)

Attachment: signature.asc
Description: Digital signature http://en.wikipedia.org/wiki/OpenPGP