Re: [PATCH 1/2] cgroup: Remove unnecessary task_lock before fetchingcss_set on migration

From: Frederic Weisbecker
Date: Tue Dec 20 2011 - 14:27:10 EST


On Tue, Dec 20, 2011 at 11:14:43AM -0800, Tejun Heo wrote:
> Hello, Frederic.
>
> On Tue, Dec 20, 2011 at 08:01:12PM +0100, Frederic Weisbecker wrote:
> > When we fetch the css_set of the tasks on cgroup migration, we don't need
> > anymore to synchronize against cgroup_exit() that could swap the old one
> > with init_css_set. Now that we are using threadgroup_lock() during
> > the migrations, we don't need to worry about it anymore.
> >
> > Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > Cc: Tejun Heo <tj@xxxxxxxxxx>
> > Cc: Li Zefan <lizf@xxxxxxxxxxxxxx>
> > Cc: Containers <containers@xxxxxxxxxxxxxxxxxxxxxxxxxx>
> > Cc: Cgroups <cgroups@xxxxxxxxxxxxxxx>
> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> > Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Cc: Paul Menage <paul@xxxxxxxxxxxxxx>
> > Cc: Mandeep Singh Baines <msb@xxxxxxxxxxxx>
>
> I like this but it doesn't apply on top of cgroup/for-3.3. It
> collides with Mandeep's patch. Can you please rebase?

Yeah it was made on top of last Mandeep's patch. Let me
rebase on top of your branch, will resend soon.

Thanks.

>
> Li, can you please ack?
>
> Thanks.
>
> --
> tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/