Re: [PATCH] intel-iommu: Add device info into list before doingcontext mapping

[Chris Wright]

* Hao, Xudong (xudong.hao@xxxxxxxxx) wrote:
> @@ -2282,6 +2276,14 @@ static int domain_add_dev_info(struct dmar_domain *domain,
>  	pdev->dev.archdata.iommu = info;
>  	spin_unlock_irqrestore(&device_domain_lock, flags);
>  
> +	ret = domain_context_mapping(domain, pdev, translation);
> +	if (ret) {
> +		list_del(&info->link);
> +		list_del(&info->global);

At the very least, this is not correct locking.

> +		free_devinfo_mem(info);
> +		return ret;
> +	}
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/