Re: [PATCH 14/16] dynamic_debug: add trim_prefix() to providesource-root relative paths

[Bart Van Assche]

On Mon, Dec 19, 2011 at 10:13 PM, Jason Baron <jbaron@xxxxxxxxxx> wrote:
> +/* Return the path relative to source root */
> +static inline const char *trim_prefix(const char *path)
> +{
> +       int skip = strlen(__FILE__) - strlen("lib/dynamic_debug.c");
> +
> +       if (strncmp(path, __FILE__, skip))
> +               skip = 0; /* prefix mismatch, don't skip */
> +
> +       return path + skip;
> +}

Isn't the preferred style to write if (strncmp(...) != 0) ..., i.e. to
mention "!= 0" explicitly instead of leaving it out when comparing
strings ?

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/