Re: [PATCH v4 3/4] regulator: simplify twl4030 config

[Felipe Contreras]

On Tue, Dec 20, 2011 at 3:19 AM, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Dec 20, 2011 at 03:15:16AM +0200, Felipe Contreras wrote:
>> If we have TWL4030_CORE and REGULATOR, we *obviously* want
>> REGULATOR_TWL4030 by default. But can be disabled if somebody wants for
>> some strange reason.
>
> No, this is the wrong way to go about this - why are you making this
> change for this one driver only?

Because that's the only one I care about. I can try to do the same for
all the others if you wish.

> Exactly the same argument would apply
> to all the other MFD regulators and to all the other MFD subdrivers in
> the various subsystems.

Yes, the ones that closely related to certain architectures or chips.

And this is already done:

REGULATOR_AB3100:
	depends on AB3100_CORE
	default y if AB3100_CORE

(if AB3100_CORE is redundant BTW)

REGULATOR_TPS6105X:
	depends on TPS6105X
	default y if TPS6105X

ditto

And in mfd:

config TPS65010
	default y if MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_OSK

config ABX500_CORE
	default y if ARCH_U300 || ARCH_U8500

config AB3100_CORE
	default y if ARCH_U300

config AB3100_OTP
	default y if AB3100_CORE

These 3 seem to be linked, but the same logic applies; most people
should say 'y', so make it the default.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/