Re: [PATCHv2 07/10] ftrace: Change filter/notrace set functions toreturn exit code

[Steven Rostedt]

On Mon, 2011-12-05 at 18:22 +0100, Jiri Olsa wrote:
> Currently the ftrace_set_filter and ftrace_set_notrace functions
> do not return any return code. So there's no way for ftrace_ops
> user to tell wether the filter was correctly applied.
> 
> The set_ftrace_filter interface returns error in case the filter
> did not match:
> 
>   # echo krava > set_ftrace_filter
>   bash: echo: write error: Invalid argument
> 
> Changing both ftrace_set_filter and ftrace_set_notrace functions
> to return zero if the filter was applied correctly or -E* values
> in case of error.

This looks like a proper fix. Move this to the front of the patch set,
as this and patch 1 can go into ftrace now as fixes.

-- Steve

> 
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/