RE: [PATCH] pinctrl: rename U300 ans SIRF pin controllers

From: Stephen Warren
Date: Mon Dec 19 2011 - 13:30:18 EST


Linus Walleij wrote at Sunday, December 18, 2011 3:47 PM:
> For stringen order, rename the pinmux-* pin controllers to

I'm not sure what "stringen order" is; perhaps "consistency"?

> pinctrl-* and also rename the Kconfig symbols and in-kernel
> users.
>
> Cc: Rongjun Ying <Rongjun.Ying@xxxxxxx>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Acked-by: Stephen Warren <swarren@xxxxxxxxxx>

Just one question though:

> diff --git a/drivers/pinctrl/pinmux-sirf.c b/drivers/pinctrl/pinctrl-sirf.c
> similarity index 100%
> rename from drivers/pinctrl/pinmux-sirf.c
> rename to drivers/pinctrl/pinctrl-sirf.c
> diff --git a/drivers/pinctrl/pinmux-u300.c b/drivers/pinctrl/pinctrl-u300.c
> similarity index 100%
> rename from drivers/pinctrl/pinmux-u300.c
> rename to drivers/pinctrl/pinctrl-u300.c

Do you want to change the DRIVER_NAME define in those two drivers and
s/pinmux/pinctrl/ there? Perhaps that's not a good idea, but I thought
I'd ask in case you meant to.

--
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/