Re: [PATCH] module: struct module_ref should contains long fields

From: Rusty Russell
Date: Mon Dec 19 2011 - 01:08:30 EST


On Fri, 16 Dec 2011 17:36:30 +0100, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> Le vendredi 16 dÃcembre 2011 Ã 08:05 -0800, Tejun Heo a Ãcrit :
> > Hello,
> >
> > On Fri, Dec 16, 2011 at 8:01 AM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> > > Its percpu data, there is no need to waste a full cache line per cpu for
> > > this.
> >
> > Hmmm.... okay. I just don't like seeing arbitrary alignment there.
> > Can you please add some comment explaining why the unusual alignment
> > is used there?
>
> Yep, thanks for the review !

Thanks, applied!

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/