Re: [PATCH] Fix for binary_sysctl() memory leak

From: Michel Lespinasse
Date: Sat Dec 17 2011 - 20:23:27 EST


On Sat, Dec 17, 2011 at 2:14 PM, Eric W. Biederman
<ebiederm@xxxxxxxxxxxx> wrote:
> Calling sysctl(2) is very rare.  I don't know if it actually happens
> anywhere with a modern userspace except in regression tests.
> Effectively we retain sysctl(2) because it doesn't take too much to
> maintain.

Agree, there is no good reason one would call sysctl() anymore.

> Michel what caused you to discover this bug?  If you are using
> sysctl(2) in production code I am a bit worried.

Well, somebody hit it :) To be honest, I'm not sure how they came to
do that. It wasn't in a datacenter setting.

--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/