Re: checkpatch.pl misreporting bugs with array fillings

[Joe Perches]

On Fri, 2011-12-16 at 22:59 +0100, Marek Vasut wrote:
> static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = {
>         {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] = 0 },
>         {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] = 0 },
> };

True.

Andy will probably figure it out.
He's the maintainer.

Still, in this case all the 0's are unnecessary.
I'd probably write that code as:

static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = {
	{ [7] = 27, [8] = 27 },
	{ [7] = 29, [8] = 29 },
};	


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/