Re: checkpatch.pl misreporting bugs with array fillings

From: Andy Whitcroft
Date: Fri Dec 16 2011 - 17:24:38 EST


On Fri, Dec 16, 2011 at 9:59 PM, Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
> Hi,
>
> the following testcase is probably misreported by checkpatch.pl:
>
> static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = {
>        {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] = 0 },
>        {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] = 0 },
> };
>
> The result is:
>
> ERROR: space prohibited before open square bracket '['
> #2: FILE: testcase.c:2:
> +       {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] = 0 },
>
> ERROR: space prohibited before open square bracket '['
> #3: FILE: testcase.c:3:
> +       {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] = 0 },
>
> total: 2 errors, 0 warnings, 5 lines checked
>
> NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX
> MULTISTATEMENT_MACRO_USE_DO_WHILE
>
> testcase.c has style problems, please review.

Hmmm will have a look...

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/