Re: Latest tip kernel(3.2-rc1-tip_cf6b3899) fails to boot on x3850x5 machine

[Yinghai Lu]

On Fri, Dec 16, 2011 at 12:40 AM, Ingo Molnar <mingo@xxxxxxx> wrote:

> IRQ_REMAP is a 'complex' option:
>
> config IRQ_REMAP
>        bool "Support for Interrupt Remapping (EXPERIMENTAL)"
>        depends on X86_64 && X86_IO_APIC && PCI_MSI && ACPI && EXPERIMENTAL
>        select DMAR_TABLE
>
> and selecting such complex options is generally dangerous, as
> the sub-dependencies are not explicitly selected. So if say
> PCI_MSI or ACPI are disabled, the select will still be performed
> by X86_X2APIC.
>
> Can we make the IRQ_REMAP default depend on X86_X2APIC or so, to
> solve this problem?

but user could use IRQ_REMAP without x2apic.

We could have

--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -286,7 +286,8 @@ config SMP

 config X86_X2APIC
        bool "Support x2apic"
-       depends on X86_LOCAL_APIC && X86_64 && IRQ_REMAP
+       depends on X86_LOCAL_APIC && X86_64 && X86_IO_APIC && PCI_MSI && ACPI
+       select IRQ_REMAP
        ---help---
          This enables x2apic support on CPUs that have this feature.

BTW:
Suresh, can we remove EXPERIMENTAL for IRQ_REMAP now?

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/