Re: [patch 1/2]block, cfq: fix empty queue crash caused by requestmerge

From: Jens Axboe
Date: Fri Dec 16 2011 - 07:56:40 EST


On 2011-12-16 02:52, Shaohua Li wrote:
> All requests of a queue could be merged to other requests of other queue.
> Such queue will not have request in it, but it's in service tree. This
> will cause kernel oops.
> I encounter a BUG_ON() in cfq_dispatch_request() with next patch, but the
> issue should exist without the patch.

Good catch, yes I think this could happen if you just happen to have a
very deliberate/unlucky set of processes and timings. Applied.


--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/