[PATCH] mm: add missing mutex lock arround notify_change

From: Djalal Harouni
Date: Fri Dec 16 2011 - 06:22:39 EST



Calls to notify_change() must hold i_mutex.

Signed-off-by: Djalal Harouni <tixxdz@xxxxxxxxxx>
---
mm/filemap.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/mm/filemap.c b/mm/filemap.c
index c106d3b..0670ec1 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1994,10 +1994,16 @@ EXPORT_SYMBOL(should_remove_suid);

static int __remove_suid(struct dentry *dentry, int kill)
{
+ int ret;
struct iattr newattrs;

newattrs.ia_valid = ATTR_FORCE | kill;
- return notify_change(dentry, &newattrs);
+
+ mutex_lock(&dentry->d_inode->i_mutex);
+ ret = notify_change(dentry, &newattrs);
+ mutex_unlock(&dentry->d_inode->i_mutex);
+
+ return ret;
}

int file_remove_suid(struct file *file)
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/