Re: [PATCH] x86: Use -m-omit-leaf-frame-pointer to shrink text size

[Ingo Molnar]

* Ingo Molnar <mingo@xxxxxxx> wrote:

> [...]
> 
> The call-chains are still intact for quality backtraces and 
> for call-chain profiling (perf record -g), as the backtrace 
> walker can deduct the full backtrace from the RIP of a leaf 
> function and the parent chain.

Hm, noticed one complication while looking at annotated assembly 
code in perf top. Code doing function calls from within asm() is 
incorrectly marked 'leaf' by GCC:

ffffffff812b82d8 <arch_local_save_flags>:
ffffffff812b82d8:       ff 14 25 00 d9 c1 81    callq  *0xffffffff81c1d900
ffffffff812b82df:       c3                      retq   

So all the paravirt details will have to be fixed, so that GCC 
is able to see that there's a real function call done inside. 
Jeremy, Konrad?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/