Re: [PATCH -resend 1/1] SPI: disable CONFIG_SPI_FSL_ESPI=m build

From: Wolfram Sang
Date: Wed Dec 07 2011 - 15:34:06 EST


On Wed, Dec 07, 2011 at 09:18:16PM +0100, Jiri Slaby wrote:
> When spi_fsl_espi is chosen to be built as a module, there is a build
> error because we test only CONFIG_SPI_FSL_ESPI in declaration of
> struct mpc8xxx_spi in drivers/spi/spi_fsl_lib.h. Also some called
> functions are not exported.
>
> So we forbid CONFIG_SPI_FSL_ESPI to be tristate here.
>
> The error looks like:
> drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_bufs':
> drivers/spi/spi_fsl_espi.c:232: error: 'struct mpc8xxx_spi' has no member named 'len'
> ...
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Acked-by: Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx>
> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
> ---
> Maybe Grant is back already?

I just picked it up in the for-linus branch I am preparing while Grant
is away.

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

Attachment: signature.asc
Description: Digital signature