Re: [PATCH] fs, proc: Introduce the /proc/<pid>/children entry v2

[Cyrill Gorcunov]

On Wed, Dec 07, 2011 at 10:27:26AM -0800, Tejun Heo wrote:
> Hello,
> 
> On Wed, Dec 07, 2011 at 01:41:44PM +0400, Cyrill Gorcunov wrote:
> > +static void children_seq_stop(struct seq_file *seq, void *v)
> > +{
> > +	rcu_read_unlock();
> > +	seq_printf(seq, "\n");
> > +}
> 
> Wouldn't this add newline on page boundary?  Newline should be printed
> at the end of the whole sequence but seq_stop() is called at buffer
> boundaries.
> 

Yeah, good point. I'll update! Thanks Tejun (somehow missed this
call in traverse()).

	Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/