RE: [PATCH 1/3 v4] usb: tegra20-ehci: Add devicetree support.

[Stephen Warren]

Jean-Christophe PLAGNIOL-VILLARD wrote at Tuesday, December 06, 2011 8:42 PM:
> On 14:17 Thu 21 Jul     , achew@xxxxxxxxxx wrote:
> > From: Andrew Chew <achew@xxxxxxxxxx>
> >
> > Add code to try to get platform data information (register base, irq,
> > modes, various tuning parameters) from device tree, if not present in board
> > files.
...
> > +static u64 tegra_ehci_dmamask = DMA_BIT_MASK(TEGRA_USB_DMA_ALIGN);
> I really does not like this
> as the dmamask is supposed to be device specific
> 
> before we put it in the soc codewhich alow to have it generic
> 
> this need to be manage a DT level
> 	dmamask = <32>
> 
> or
> 	dmamask = <0xffffffff>

Jean-Christophe,

The patch you're replying to is very old; Olof has posted (and applied)
some basic USB bindings much more recently than the above.

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/