RE: [PATCH] ARM: SAMSUNG: Use kmemdup rather than duplicating itsimplementation

[Kukjin Kim]

Thomas Meyer wrote:
> 
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/memdup.cocci.
> 
> Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>
> ---
> 
> diff -u -p a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
> --- a/arch/arm/plat-s3c24xx/dma.c 2011-11-07 19:37:20.736205210 +0100
> +++ b/arch/arm/plat-s3c24xx/dma.c 2011-11-08 11:03:41.719762852 +0100
> @@ -1437,11 +1437,10 @@ int __init s3c24xx_dma_init_map(struct s
>  	size_t map_sz = sizeof(*nmap) * sel->map_size;
>  	int ptr;
> 
> -	nmap = kmalloc(map_sz, GFP_KERNEL);
> +	nmap = kmemdup(sel->map, map_sz, GFP_KERNEL);
>  	if (nmap == NULL)
>  		return -ENOMEM;
> 
> -	memcpy(nmap, sel->map, map_sz);
>  	memcpy(&dma_sel, sel, sizeof(*sel));
> 
>  	dma_sel.map = nmap;

Yes, looks ok to me, will apply.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/