Re: [PATCH] Driver core: leave runtime PM enabled during systemshutdown

From: Greg KH
Date: Tue Dec 06 2011 - 16:49:05 EST


On Tue, Dec 06, 2011 at 10:26:14AM -0500, Alan Stern wrote:
> Disabling all runtime PM during system shutdown turns out not to be a
> good idea, because some devices may need to be woken up from a
> low-power state at that time.
>
> The whole point of disabling runtime PM for system shutdown was to
> prevent untimely runtime-suspend method calls. This patch (as1504)
> accomplishes the same result by incrementing the usage count for each
> device and waiting for ongoing runtime-PM callbacks to finish. This
> is what we already do during system suspend and hibernation, which
> makes sense since the shutdown method is pretty much a legacy analog
> of the pm->poweroff method.
>
> This fixes a regression on some OMAP systems.
>
> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Reported-by: NeilBrown <neilb@xxxxxxx>
> CC: Chen Peter-B29397 <B29397@xxxxxxxxxxxxx>

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

Rafael, you will take this in your tree, right?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/