Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver

From: Rob Herring
Date: Tue Dec 06 2011 - 14:56:07 EST


On 12/06/2011 05:49 AM, Russell King - ARM Linux wrote:
> On Tue, Dec 06, 2011 at 11:37:35AM +0000, Dave Martin wrote:
>> 1) All OF code and drivers should be migrating to use 0 instead of NO_IRQ
>> for the no-interrupt case. Code which receives irq numbers directly
>> from the OF framework and refers to NO_IRQ, or expects 0 to be a valid
>> needs to be fixed.
>>
>> 2) Where we hit a problem, board code needs to be adapted to remap HW IRQs
>> 0-15 to different software values. (This could be done using irq
>> domains, or not)
>
> No AMBA driver I'm aware of ever uses an IRQ number 0 or is passed such
> an IRQ number.

The watchdog on VersatileAB is on Linux IRQ0. This is easily fixed with
VIC irqdomain patches which are queued up.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/