Re: [PATCH 4/5 resend] VFS: Rename vfs_check_frozen() tovfs_block_until_thawed()

From: Christoph Hellwig
Date: Tue Dec 06 2011 - 06:40:32 EST


On Mon, Dec 05, 2011 at 12:54:48PM -0800, Kamal Mostafa wrote:
> From: Valerie Aurora <val@xxxxxxxxxxxxxxxxx>
>
> The name of vfs_check_frozen() tends to de-emphasize an important
> fact: that it will block until the file system thaws to the specified
> level. Make bugs slightly less likely by renaming to
> vfs_block_until_thawed().

I really hate that name. The old one wasn't perfect either, but unless
you have a really good new one I'm strongly in favour of not repainting
the bikeshed.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/