Re: [PATCH v4 0/7] x86: BSP or CPU0 online/offline

From: Srivatsa S. Bhat
Date: Tue Dec 06 2011 - 05:48:35 EST


On 12/06/2011 04:05 PM, Ingo Molnar wrote:

>
> * Srivatsa S. Bhat <srivatsa.bhat@xxxxxxxxxxxxxxxxxx> wrote:
>
>>> But the hibernation angle should be considered. Hibernation
>>> already has to deal with the case where someone physically
>>> unplugs a CPU and then resumes from the disk image, right?
>>> How does the hibernation code handle that case currently?
>>
>> Oh, wait a minute. Are we talking about physical CPU Hotplug
>> in between hibernation and restore? AFAIK, currently we don't
>> handle that at all. [...]
>
> Well, not hotplug, but plain old-fashioned: 'hibernate the box,
> take out a CPU physically and thaw' kind of hardware change.
>


Well, actually that's what I meant, taking this same idea a bit
further: hibernate the box, take out a CPU physically, insert a
slightly different CPU (which needs a different microcode image)
and thaw.

In this case, the other patch that I mentioned in my previous mail
would be required (or an equivalent), because the optimization
patch which is now in mainline, would apply the same old microcode
image on this new CPU too, blindly.


> How will the hibernation code handle this case?


I am not familiar with how the rest of the hibernation code handles
the case you described. I just happen to know about the microcode
case needing some more work for this to work reliably.

Regards,
Srivatsa S. Bhat
IBM Linux Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/