Re: [alsa-devel] [PATCH v2] soc/lapis: add machine driver

From: Mark Brown
Date: Tue Dec 06 2011 - 05:25:23 EST


On Tue, Dec 06, 2011 at 11:37:52AM +0900, Tomoya MORINAGA wrote:

> Thanks. However, i2c access code is not included in Samsung.
> Though OMAP includes i2c access code like below,
> omap/sdp3430.c: twl_i2c_read_u8(TWL4030_MODULE_INTBR, &pin_mux,
> omap/sdp3430.c: twl_i2c_write_u8(TWL4030_MODULE_INTBR, pin_mux,
> this code doesn't seem applicable for me.

> Could you show best practice for i2c access of machine driver?

I2C access by machine drivers is not good practice. If you must do it
for some reason use the standard ASoC functions to read and write
registers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/