Re: [patch v3 3/6] sched, nohz: sched group, domain aware nohz idleload balancing

[Srivatsa Vaddagiri]

* Suresh Siddha <suresh.b.siddha@xxxxxxxxx> [2011-12-01 17:07:34]:

> @@ -5090,7 +5019,7 @@ static void nohz_idle_balance(int this_c
>  		goto end;
> 
>  	for_each_cpu(balance_cpu, nohz.idle_cpus_mask) {
> -		if (balance_cpu == this_cpu)
> +		if (balance_cpu == this_cpu || !idle_cpu(this_cpu))
>  			continue;

Hmm ..did you mean to use '!idle_cpu(balance_cpu)' there? If the intent
was on checking this_cpu becoming busy, then we'd rather do a break on
that condition rather than continuing with the loop?

- vatsa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/