Re: [PATCH 01/12] perf_events: add generic taken branch samplingsupport (v2)

[Peter Zijlstra]

On Fri, 2011-10-14 at 14:37 +0200, Stephane Eranian wrote:
> +#define PERF_SAMPLE_BRANCH_PLM_ALL \
> +       (PERF_SAMPLE_BRANCH_USER|\
> +        PERF_SAMPLE_BRANCH_KERNEL) 

This PLM thing keeps popping up all over, I'm sure it stands for
something, but for now it just hurts my eyes.


> +               /* at least one branch bit must be set */
> +               if (!(mask & ~PERF_SAMPLE_BRANCH_PLM_ALL))
> +                       return -EINVAL;
> 
Why? we can create counters with exclude_user && exclude_kernel as well,
I mean, they're useless, but its perfectly valid.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/