Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver

From: Geert Uytterhoeven
Date: Mon Dec 05 2011 - 13:15:51 EST


On Mon, Dec 5, 2011 at 19:02, Dave Martin <dave.martin@xxxxxxxxxx> wrote:
> Unfortunately, NO_IRQ is often not spelled "NO_IRQ". ÂIt looks like the assumption
> "irq < 0 === no irq" may be quite a lot more widespread than "NO_IRQ === no irq".

Can we make irq unsigned, and hope the compiler catches all of them
(comparison always
false blah blah blah)?

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/