Re: [PATCH 2/2 v4] pinctrl: introduce generic pin config

From: Mark Brown
Date: Mon Dec 05 2011 - 10:37:26 EST


On Mon, Dec 05, 2011 at 02:35:07PM +0100, Linus Walleij wrote:
> On Thu, Dec 1, 2011 at 6:16 PM, Stephen Warren <swarren@xxxxxxxxxx> wrote:

> > I think that'd be fine; the generic code would do all the debug prints
> > for the standardized enums, then the core would call into the pinctrl
> > driver to perform any additional debug prints for any driver-defined
> > custom parameters.

> I think Marks point earlier was that he wanted the possibility
> to cut out *all* the generic stuff and have only custom config
> enumerators for a certain pin controller.

Pretty much. Or at least have a way of doing that. But I do think this
should have a way of coexisting with the standard properties where
that's possible.

My main concern here is that going through too much of an abstraction
layer looks like it could be an awful lot more work and I'm not entirely
clear what it'd buy us - things like readback debug decode into user
readable values are an example of a useful thing, though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/